tipc: fix a possible memleak in tipc_buf_append
authorXin Long <lucien.xin@gmail.com>
Tue, 30 Apr 2024 14:03:38 +0000 (10:03 -0400)
committerSalvatore Bonaccorso <carnil@debian.org>
Fri, 3 May 2024 12:40:24 +0000 (14:40 +0200)
commitb3bc8fcce13f3eeb6890dcbbd30d4ff6be71adb2
treeee20f45834a36e3d696bd89600b46e271c1e4256
parent61119201822885f2f0c274a1139062525feaf05f
tipc: fix a possible memleak in tipc_buf_append

Origin: https://git.kernel.org/linus/97bf6f81b29a8efaf5d0983251a7450e5794370d

__skb_linearize() doesn't free the skb when it fails, so move
'*buf = NULL' after __skb_linearize(), so that the skb can be
freed on the err path.

Fixes: b7df21cf1b79 ("tipc: skb_linearize the head skb when reassembling msgs")
Reported-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Tung Nguyen <tung.q.nguyen@dektech.com.au>
Link: https://lore.kernel.org/r/90710748c29a1521efac4f75ea01b3b7e61414cf.1714485818.git.lucien.xin@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Gbp-Pq: Topic bugfix/all
Gbp-Pq: Name tipc-fix-a-possible-memleak-in-tipc_buf_append.patch
net/tipc/msg.c